[alsa-devel] [PATCH] opti931: additional check for OPL3 device

[Takashi Iwai]

At Mon, 17 Sep 2007 16:45:55 +0200,
Krzysztof Helt wrote:
> 
> On Mon, 17 Sep 2007 14:40:51 +0200
> Rene Herman <rene.herman at gmail.com> wrote:
> 
> > The OPL4 is at 0x380, with its OPL3 compatible part at 0x388. Could you add 
> > an Acked-by?
> > 
> You are inpatient. I have tested it on my opti933.
> 
> > ===
> > opti9xx: adjust OPL3 FM resource value
> > 
> > The OPTi ISA-PnP chips advertise their OPL4 base at 0x380 (to 0x3f0) through 
> >   pnp and put their on-chip OPL3 at +8. The driver assumes the provided 
> > value is the ALBase (OPL3 address) though and checks for an OPL4 at -8, 
> > which means that simply adding 8 to the pnp provides value works to fix 
> > detection of both OPL3 and OPL4.
> > 
> > Problem spotted on 931 and 933 by Krzysztof Helt and confirmed on 924 and 
> > 925 (together all OPTi ISA-PnP chips) by me.
> > 
> > Signed-off-by; Rene Herman <rene.herman at gmail.com>
> 
> Acked-by: Krzysztof Helt <krzysztof.h1 at wp.pl>

Guys, let's relax.  Now it's merged to HG tree.


thanks,

Takashi