[alsa-devel] [PATCH] sscape: support for audio part of VIVO cards

[Krzysztof Helt]

On Mon, 17 Sep 2007 14:30:22 +0200
Takashi Iwai <tiwai at suse.de> wrote:

> At Sun, 16 Sep 2007 22:50:24 +0200,
> Krzysztof Helt wrote:
> > 
> > @@ -358,6 +360,8 @@ static void soundscape_free(struct snd_c
> >  {
> >  	register struct soundscape *sscape = get_card_soundscape(c);
> >  	release_and_free_resource(sscape->io_res);
> > +	if (sscape->wss_res)
> > +		release_and_free_resource(sscape->wss_res);
> 
> You don't need NULL check here.
> 

I need it as the SS PnP does not request a separate region for codec (wss_port). So the SS PnP do not allocate this resource and it must not be freed.

> > @@ -1253,6 +1323,8 @@ _release_dma:
> >  	free_dma(dma1[dev]);
> >  
> >  _release_region:
> > +	if (wss_res)
> > +		release_and_free_resource(wss_res);
> 

The same as the above. The SS PnP never sets wss_ret.

Regards,
Krzysztof