[alsa-devel] [PATCH] ad1848 and cs4231 busy loop replacement

[Rene Herman]

On 09/10/2007 07:05 PM, Krzysztof Helt wrote:

> Rene Herman <rene.herman at gmail.com> wrote:

>> No, waiting for calibration the be under way is what my 0/1 ms does.
>> You are waiting for it to be nearly done, which is complete nonsense.
>> One line below we are waiting for 250 ms (generally with _one_ pass
>> through the loop -- we only wake up through signals) anyway!
> 
> I don't buy your argument that it is complete nonsense.

You don't need to buy it -- I presented it to you for free on a fucking 
platter 4 times now. You are making me waste my time. Answer this or just 
bury this useles nonsense discussion: why do you insist on delaying for 7 ms 
when the specification says (and the hardware is confirming) that 1 ms is 
enough?

You are delaying 7 ms and then 250 ms when we are auto-calibrating. I delay 
1 ms and then 250 ms when we are auto-calibrating. Why do you delay longer 
than the hardware needs and make everyone who ever reads this code wonder 
why the hell that odd delay is in there? And make everyone who ever will be 
re-writing or porting this code drag it along on the notion that someone, 
somewhere probably once had a purpose for it?

Fix it up with a comment? Why? There's still not a single point to it.

Why 7? Or 2? Or whatever more time than needed for the calibration to start?

> Also comments like "my way or highway" (NAK) won't make you many friends.

Good, I don't need more friends. You are doing the generic newbie thing 
where you assume you obviously must know everything better than everyone 
else. Just shelve that dumb crap.

You also may want to take into account that I'm taking the time to review 
your code and dig trough datasheets while I had in fact different things to 
do and it's proving utterly useless.

Fixed patch attached.

Rene.
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: mce_down.diff
Url: http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20070910/fd4b2df1/attachment.bat