[alsa-devel] [PATCH] Improved support for different bt87x board configurations

Mauro Carvalho Chehab mchehab at infradead.org
Sat Sep 8 02:33:36 CEST 2007

> > Reviewed-by: Mauro Carvalho Chehab <mchehab at infradead.org>
> Thanks, but I have already committed, and don't want to rollback now
> :)
No problem ;)

> BTW, how is this tag supposed to use?

This is a new tag that were agreed to be used informally at KS/2007 :)

The idea behind is to use the following logic:

Signed-off-by: - should be used by the author(s) and the trees for what
the patch passed. A maintainer should add this tag to confirm that he
received a patch by its author or from a sub-subsystem tree (in fact,
sometimes, this tag is abused);

Acked-by: - this simply means that you aren't against some patch;

Reviewed-by: - It means that somebody that are not at the direct
forwarding way of a patch has reviewed and/or tested a patch.

So, in this case, as Trent sent the patch directly to you (even I'm
being C/C), I should use either acked-by (if I'm just ok with this) or
reviewed-by. As I've reviewed the source code, reviewed-by is the better

Also, subsystem maintainers are asked to require at least one
reviewed-by by patch. The idea is to stimulate the community to review
changesets and improve the overall quality of the kernel.

>  On git or Hg, it's hard to
>  change the already committed stuff, especially after openly
>  published...)

What I do here is: I don't change -hg tree. During my -git conversion, I
add such tags that I receive from third parties, even for patches
already published at kernel.org. I only stop adding tags after asking a
git pull.

Here, I'm still using stgit porcelain to allow me to review changesets,
but this is not recommended. Probably, I'll review my procedures.
However, git have already some way for you to edit a message for an
already-edited changeset.

On possible way would be do to this - supposing that you want to edit
the patch that is HEAD - 3 patches from your master branch:

git checkout HEAD~3
git commit -e --amend
	(edit the comments)
git chckout master

I didn't really tested the above procedure, so I would try this on an
experimental tree first.
> Takashi

More information about the Alsa-devel mailing list