[alsa-devel] [PATCH] ad1848_lib: replace common delay loop by function
tiwai at suse.de
Wed Sep 5 15:02:53 CEST 2007
At Wed, 05 Sep 2007 00:41:25 +0200,
Rene Herman wrote:
> On 09/04/2007 11:53 PM, Krzysztof Helt wrote:
> > +static void snd_ad1848_ready(struct snd_ad1848 *chip)
> Same request for a name change -- "ready" sounds boolean to me...
Agreed. Also, the error output of timeout can be better in
> > -#if 0
> > - printk("codec out - reg 0x%x = 0x%x\n", chip->mce_bit | reg, value);
> > -#endif
Well, I think it's ok to remove such dead codes. If it's really
supposed to revive, they shouldn't be #if 0 but with other macros,
such as snd_printdd().
More information about the Alsa-devel