[alsa-devel] [PATCH] sgalaxy: checkpatch fixes

Rene Herman rene.herman at gmail.com
Wed Sep 5 14:23:09 CEST 2007

On 09/05/2007 06:47 AM, Krzysztof Helt wrote:

> I about acquring the SG Waverider card. I saw your driver and thought 
> about asking you to cooperate to merge you driver into the sgalaxy or
> polish the driver more. You are just one step before me.

Ah, recently grabbed a Waverider as well. I now have some 15 Sound Galaxy 
models I believe which is partly why testing them all is taking too 
much/long ;-)

Will make time now though.

> Yes, but as I am about merging your patch into the sgalaxy
> (my first idea).
> I want to avoid situation with patches being rejected due
>  to coding style problem in context lines.

Nah, really the only "important" thing is (while you're there) to do the "if 
((err = ))" breaking -- noone here is religious about the rest.

But, well, forgetting all about sgalaxy.c makes as much sense. The new 
driver already support more models anyway (the ones without EEPROMs).


More information about the Alsa-devel mailing list