[alsa-devel] [PATCH] sun-cs4231: memory management fix

Krzysztof Helt krzysztof.h1 at wp.pl
Tue Sep 4 21:15:25 CEST 2007


From: Krzysztof Helt <krzysztof.h1 at wp.pl>

The chip structure is now allocated by snd_card_new()
and it must not be released by separate kfree().

Signed-off-by: Krzysztof Helt <krzysztof.h1 at wp.pl>
---

This bug was introduced by the previous patch.

--- linux-2.6.23.ref/sound/sparc/cs4231.c	2007-09-03 16:03:46.000000000 +0200
+++ linux-2.6.23/sound/sparc/cs4231.c	2007-09-04 18:02:34.000000000 +0200
@@ -1865,8 +1865,6 @@ static int snd_cs4231_sbus_free(struct s
 	if (chip->port)
 		sbus_iounmap(chip->port, chip->regs_size);
 
-	kfree(chip);
-
 	return 0;
 }
 
@@ -2037,8 +2035,6 @@ static int snd_cs4231_ebus_free(struct s
 	if (chip->port)
 		iounmap(chip->port);
 
-	kfree(chip);
-
 	return 0;
 }
 


More information about the Alsa-devel mailing list