[alsa-devel] [PATCH] sun-cs4231: code improvements (2nd version)

Takashi Iwai tiwai at suse.de
Tue Sep 4 13:11:26 CEST 2007

At Mon, 3 Sep 2007 18:41:44 +0200,
Krzysztof Helt wrote:
> From: Krzysztof Helt <krzysztof.h1 at wp.pl>
> This patch does some code improvements to make
> driver (both code and binary) shorter.
> It also make use of card->private_data pointer to
> store chip information.
> Signed-off-by: Krzysztof Helt <krzysztof.h1 at wp.pl>

Thanks, now applied to HG tree.

> ---
> Do I understand correctly, that lines:
> if ((err = function()) < 0) 
> are passe now?


> They are so abudant in the alsa code, that I thought it is some kind of template code.

Yep, it was in an example code.  And we have still many of them.
But such a clean up is a low-priority task, so I haven't done much
yet.  Still, it's better not to have such lines in a new patch, at


More information about the Alsa-devel mailing list