[alsa-devel] [PATCH] dbri: conversion to OpenFirmware framework

Takashi Iwai tiwai at suse.de
Mon Sep 3 14:56:44 CEST 2007

At Sun, 2 Sep 2007 09:31:09 +0200,
Krzysztof Helt wrote:
> From: Krzysztof Helt <krzysztof.h1 at wp.pl>
> This patch converts the dbri driver to use OF framework.
> Signed-off-by: Krzysztof Helt <krzysztof.h1 at wp.pl>
> ---
> This patch requires the previous dbri patch with more
> code improvements posted yesterday.

The conversion from __init to __devinit is still missing in some
places.  This could result in oops.

Otherwise the change looks almost good to me.  But, please fix
"if ((err = ...))" if you change that line, too :)



More information about the Alsa-devel mailing list