[alsa-devel] [PATCH 2/2] sis7019: add support for pre-2.6 kernels

Dave Dillow dave at thedillows.org
Wed Nov 28 14:18:57 CET 2007

On Wed, 2007-11-28 at 10:41 +0100, Takashi Iwai wrote:
> At Wed, 28 Nov 2007 02:19:12 -0500,
> Dave Dillow wrote:
> > 
> > The sis7019 driver uses __ffs(), which is available in 2.6 kernels, but
> > not in most earlier ones. This patches the driver to use a local version
> > assembly version, as the hardware is SiS 55x only (i486/Pentium-ish).
> Then it'd be better to add the dependency on CONFIG_X86_32 so that it
> won't be compiled on other architectures.

Doh! Of course... 

> Also, replace __ffs() only for 2.4 kernels, e.g.

I'm 50/50 on this -- it doesn't hurt to just use the patched in version,
even in 2.6. I'm not fond of #ifdefs in code, and I'd need to search for
when it became available.

Then again, it is a small patch and the research isn't hard, just a bit
time consuming.


More information about the Alsa-devel mailing list