[alsa-devel] rate plugin issue

Stas Sergeev stsp at aknet.ru
Mon Nov 12 20:25:17 CET 2007


Takashi Iwai wrote:
> I committed your patch now on HG tree, as it's likely OK from the
> possible breakage on other apps, too.
OK, first I have to apologize for
not providing a test-case - its still
in my todo if you need it. There are
still a few things unclear, like, for
example, how it fixes the portaudio,
if, as you say, such an apps are not
touching the code in question.

Anyway... as I said already, there are
few more problems that were hidden
before and are not any more. (I really
tried to warn you :)
For example, mpg123 will now consume
100% of CPU because of the nasty loop
in snd_pcm_write_areas()...
I am using something like the attached
patch, but maybe you can come up with
the better solution.
Quick summary: mpg123 sets avail_min=1,
so the loop spins without any rest.
Before, the value was "adjusted", so
it didn't spin that nasty way.

> Anyway, I swear that I'll never read any mails during my next
> vacation.  That was so exhausting to be dragged to a lengthy
> discussion for band-aiding a badly designed compoment... :)
But now, unfortunately, you won't get
away from that. :)
The hack used to cover more problems...

-------------- next part --------------
A non-text attachment was scrubbed...
Name: pcm.c.diff
Type: text/x-patch
Size: 1084 bytes
Desc: not available
Url : http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20071112/fda5ee06/attachment.diff 

More information about the Alsa-devel mailing list