[alsa-devel] Function ap192_4wire_start in revo.c
    dustin at seznam.cz 
    dustin at seznam.cz
       
    Thu Mar 29 11:14:50 CEST 2007
    
    
  
Hello, while working on support for AK4114 in Audiotrak MI/ODI/O, I have come accross a bug in revo.c (used for major inspiration :)  )The function
static unsigned char ap192_4wire_start(struct snd_ice1712 *ice)
returns value of current GPIO bits, which is unsigned int. However, return value of the function is unsigned char. This results in clearing all GPIO8-22 in next snd_ice1712_gpio_write call of the 4-wire protocol communication which is a little bit inconvenient :).
Thanks for fixing in HG.
Best regards,
Pavel.
    
    
More information about the Alsa-devel
mailing list