[alsa-devel] [PATCH -mm] sound/pci/au88x0/au88x0_a3d.c remove unused code

[Michal Piotrowski]

Hi Rene,

Rene Herman napisał(a):
> On 03/25/2007 05:50 PM, Michal Piotrowski wrote:
> 
>> This patch is against the latest -mm snapshot.
> 
> The maintainers of the drivers you submitted these against are in a
> better position to comment but generally I wish people wouldn't do this.
> 
> Disabled code normally serves as a reminder of how things either should
> or could be done, sometimes how they were done before, but aren't done
> currently and the developer made them into a comment for the reason of
> maybe wanting to revisit that decision later.
> 
> It's not in the way. With a possible exception for some really old cruft
> that's just sitting there taking up space in drivers that aren't being
> maintained, I believe this should generally be left alone.
> 
> Rene.
> 

I think, that nobody cares about this '#if 0's

$ git-whatchanged sound/pci/au88x0/au88x0_a3d.c | grep commit
commit f40b68903ccd511ea9d658b4bce319dd032a265a
commit 2fd16874aa6322e8b61879a78f3b485999506833
commit 99b359ba10a582148c6725f428a33ba5356dd993

$ git-show f40b68903ccd511ea9d658b4bce319dd032a265a | grep "#if 0"
$ git-show 2fd16874aa6322e8b61879a78f3b485999506833 | grep "#if 0"
$ git-show 99b359ba10a582148c6725f428a33ba5356dd993 | grep "#if 0"
@@ -260,7 +260,7 @@ #if 0       // it's nice for read tests
 #if 0
@@ -214,13 +214,13 @@ #if 0
 #if 0
-#if 0
 #if 0
 #if 0
 #if 0
 #if 0
-#if 0
@@ -303,7 +303,7 @@ #if 0
 #if 0                          /* the loop here needs to be much better if we want it.. */
 #if 0  // only for my testing purpose --jk
 #if 0 /* FIXME: we don't support the second codec yet so skip the detection now.. */

Regards,
Michal

-- 
Michal K. K. Piotrowski
LTG - Linux Testers Group (PL)
(http://www.stardust.webpages.pl/ltg/)
LTG - Linux Testers Group (EN)
(http://www.stardust.webpages.pl/linux_testers_group_en/)