[alsa-devel] [PATCH] hda-codec - Fix definition of AC_KNBCAP_DELTA to match datasheet.

[Takashi Iwai]

At Tue, 4 Dec 2007 02:12:48 -0500,
Andrew Paprocki wrote:
> 
> hda-codec - Fix definition of AC_KNBCAP_DELTA to match datasheet.
> 
> AC_KNBCAP_DELTA is incorrectly defined as (1<<8). According to the ALC883
> datasheet rev 1.3, this is bit 7 after AC_KNBCAP_NUM_STEPS which is a 0x7f
> mask.
> 
> Signed-off-by: Andrew Paprocki <andrew at ishiboo.com>

This is a broken patch, too.  Please fix.


Thanks,

Takashi

> 
> 
> diff -r da002fb740a42b4fd6dcbd45693f9bee3c828812 -r
> 65b577e690e95e4ace950c3f986270dd3e992192 pci/hda/hda_codec.h
> --- a/pci/hda/hda_codec.h       Mon Dec 03 22:52:58 2007 -0500
> +++ b/pci/hda/hda_codec.h       Mon Dec 03 23:02:51 2007 -0500
> @@ -238,7 +238,7 @@ enum {
> 
>  /* Volume knobs capabilities */
>  #define AC_KNBCAP_NUM_STEPS            (0x7f<<0)
> -#define AC_KNBCAP_DELTA                        (1<<8)
> +#define AC_KNBCAP_DELTA                        (1<<7)
> 
>  /*
>   * Control Parameters
>