[alsa-devel] [alsa-cvslog] alsa-kernel: cmipci: disable "Modem" control on version 39 or newer chips
tvignaud at mandriva.com
Mon Dec 10 18:23:56 CET 2007
"Clemens Ladisch" <clemens at ladisch.de> writes:
> > > description:
> > > cmipci: disable "Modem" control on version 39 or newer chips
> > >
> > > On version 39 or newer chips, we better remove the "Modem" control
> > > because this register bit now mutes the front channels of the
> > > multichannel stream.
> > shouldn't that deserve a comment in the code?
> Not in my opinion. The "if (version < 39)" makes clear in which
> version the control is used, and both the old and new bits are
> documented in the respective data sheets.
Still a comment would prevent forcing people do double check the data
sheets in order to understand the code...
More information about the Alsa-devel